From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbcCXJrV (ORCPT ); Thu, 24 Mar 2016 05:47:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47431 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754686AbcCXJrP (ORCPT ); Thu, 24 Mar 2016 05:47:15 -0400 Date: Thu, 24 Mar 2016 10:47:11 +0100 From: Jiri Olsa To: Peter Zijlstra Cc: Jiri Olsa , Steven Rostedt , lkml , Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Message-ID: <20160324094711.GB8893@krava.brq.redhat.com> References: <1458138873-1553-1-git-send-email-jolsa@kernel.org> <1458138873-1553-4-git-send-email-jolsa@kernel.org> <20160323142653.GA6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160323142653.GA6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2016 at 03:26:53PM +0100, Peter Zijlstra wrote: > On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote: > > Fixing this by using ftrace_ops::private value to keep > > the perf_event pointer. This way we don't need to search > > for triggered event (as tracepoint handler does) and > > directly store sample. > > container_of(ops, struct perf_event, ftrace_ops) would also have worked, > right? yes, I think that would work too jirka