From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756267AbcCXNbS (ORCPT <rfc822;w@1wt.eu>);
	Thu, 24 Mar 2016 09:31:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47968 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755309AbcCXNbD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 24 Mar 2016 09:31:03 -0400
Date: Thu, 24 Mar 2016 14:30:59 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: gg@twins.programming.kicks-ass.net, Jiri Olsa <jolsa@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to
 init event
Message-ID: <20160324133059.GA22759@krava.brq.redhat.com>
References: <1458138873-1553-1-git-send-email-jolsa@kernel.org>
 <1458138873-1553-3-git-send-email-jolsa@kernel.org>
 <20160323104129.GZ6344@twins.programming.kicks-ass.net>
 <20160324095648.GC8893@krava.brq.redhat.com>
 <20160324104934.GQ6356@twins.programming.kicks-ass.net>
 <20160324122544.GA12449@krava.brq.redhat.com>
 <20160324130045.GR6356@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160324130045.GR6356@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 24, 2016 at 02:00:45PM +0100, Peter Zijlstra wrote:
> On Thu, Mar 24, 2016 at 01:25:44PM +0100, Jiri Olsa wrote:
> > > > > >   $ sudo perf record -e sched:sched_switch:u ls
> > > > > >   $ sudo /perf script | wc -l
> > > > > >   0
> 
> > > And its not like the [uk] flags are hard to implement here.
> > 
> > sched:sched_switch:u ?
> 
> As per the above, its implemented and correct. The answer is 0.
> 
> The only problem is that currently it assumes all tracepoint events are
> from the kernel, and that is wrong for uprobes.
> 
> But returning an error is not right, its a valid configuration, a daft
> one, sure, but not invalid.
> 
> Similarly uprobe:foo:k is daft, but broken.

ok, will send fix for uprobes then

thanks,
jirka