From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754045AbcCZSzn (ORCPT ); Sat, 26 Mar 2016 14:55:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:57273 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbcCZSzj (ORCPT ); Sat, 26 Mar 2016 14:55:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,396,1455004800"; d="scan'208";a="676047809" Date: Sun, 27 Mar 2016 02:54:23 +0800 From: kbuild test robot To: Mike Marshall Cc: kbuild-all@01.org, linux-fsdevel@vger.kernel.org, pvfs2-developers@beowulf-underground.org, linux-kernel@vger.kernel.org Subject: [PATCH] Orangefs: fix ifnullfree.cocci warnings Message-ID: <20160326185423.GA91872@lkp-hsx03> References: <201603270220.V8jU4hSN%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201603270220.V8jU4hSN%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fs/orangefs/orangefs-debugfs.c:130:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Fengguang Wu --- orangefs-debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c @@ -126,8 +126,7 @@ out: void orangefs_debugfs_cleanup(void) { - if (debug_dir) - debugfs_remove_recursive(debug_dir); + debugfs_remove_recursive(debug_dir); } /* open ORANGEFS_KMOD_DEBUG_HELP_FILE */