mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>,
	adrian.hunter@intel.com
Subject: Re: [PATCH 3/4] perf, tools, script: Add support for printing assembler
Date: Sun, 27 Mar 2016 13:05:01 +0200	[thread overview]
Message-ID: <20160327110501.GA4015@krava.sund.root.ku.dk> (raw)
In-Reply-To: <1458946958-27570-3-git-send-email-andi@firstfloor.org>

On Fri, Mar 25, 2016 at 04:02:37PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When dumping PT traces with perf script it is very useful to see the
> assembler for each sample, so that it is easily possible to follow
> the control flow.
> 
> As using objdump is difficult and inefficient from perf script this
> patch uses the udis86 library to implement assembler output.
> The library can be downloaded from http://udis86.sourceforge.net/
> 
> The library is probed as an external dependency in the usual way. Then perf
> script calls into it when needed, and handles callbacks to resolve
> symbols.
> 
> % perf record -e intel_pt//u true
> % perf script -F sym,symoff,ip,asm --itrace=i0ns | head
>      7fc7188b4190 _start+0x0	mov %rsp, %rdi
>      7fc7188b4193 _start+0x3	call _dl_start
>      7fc7188b7710 _dl_start+0x0	push %rbp
>      7fc7188b7711 _dl_start+0x1	mov %rsp, %rbp
>      7fc7188b7714 _dl_start+0x4	push %r15
>      7fc7188b7716 _dl_start+0x6	push %r14
>      7fc7188b7718 _dl_start+0x8	push %r13
>      7fc7188b771a _dl_start+0xa	push %r12
>      7fc7188b771c _dl_start+0xc	mov %rdi, %r12
>      7fc7188b771f _dl_start+0xf	push %rbx
> 
> Current issues:
> - Some jump references do not get resolved to symbols.
> - udis86 release does not support STAC/CLAC, which are used in the kernel,
> but there is a pending patch for it.

can't apply this on latest Arnaldo's tree:

patching file Documentation/perf-script.txt
patching file builtin-script.c
Hunk #5 succeeded at 431 (offset -2 lines).
Hunk #6 succeeded at 832 with fuzz 2 (offset -10 lines).
Hunk #7 FAILED at 871.
Hunk #8 succeeded at 890 with fuzz 2 (offset -10 lines).
Hunk #9 succeeded at 899 (offset -10 lines).
Hunk #10 FAILED at 1018.
Hunk #11 succeeded at 2108 (offset -10 lines).
2 out of 11 hunks FAILED -- saving rejects to file builtin-script.c.rej


jirka

  reply	other threads:[~2016-03-27 11:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 23:02 [PATCH 1/4] perf, tools: Add support for skipping itrace instructions Andi Kleen
2016-03-25 23:02 ` [PATCH 2/4] perf, tools: Add probing for udev86 Andi Kleen
2016-03-27 11:26   ` Jiri Olsa
2016-03-25 23:02 ` [PATCH 3/4] perf, tools, script: Add support for printing assembler Andi Kleen
2016-03-27 11:05   ` Jiri Olsa [this message]
2016-03-27 15:35     ` Andi Kleen
2016-03-25 23:02 ` [PATCH 4/4] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-03  9:00 New attempt at adding an disassembler to perf Andi Kleen
2017-01-03  9:00 ` [PATCH 3/4] perf, tools, script: Add support for printing assembler Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160327110501.GA4015@krava.sund.root.ku.dk \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®