From: Mark Brown <broonie@kernel.org>
To: Maarten ter Huurne <maarten@treewalker.org>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] regulator: act8865: Pass of_node via act8865_regulator_data
Date: Mon, 28 Mar 2016 12:35:21 -0700 [thread overview]
Message-ID: <20160328193521.GH2350@sirena.org.uk> (raw)
In-Reply-To: <1458223508-20740-3-git-send-email-maarten@treewalker.org>
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
On Thu, Mar 17, 2016 at 03:05:07PM +0100, Maarten ter Huurne wrote:
> This makes the code easier to read and it avoids a dynamic memory
> allocation.
Please write better changelogs. This is a very fiddly and non obvious
set of transformations and it takes far too much effort to work out what
this change does and why it's safe.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-29 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 14:05 [PATCH v2 1/4] regulator: act8865: Remove redundant dev lookups Maarten ter Huurne
2016-03-17 14:05 ` [PATCH v2 2/4] regulator: act8865: Remove "too many regulators" error handler Maarten ter Huurne
2016-03-23 13:43 ` Applied "regulator: act8865: Remove "too many regulators" error handler" to the regulator tree Mark Brown
2016-03-17 14:05 ` [PATCH v2 3/4] regulator: act8865: Pass of_node via act8865_regulator_data Maarten ter Huurne
2016-03-28 19:35 ` Mark Brown [this message]
2016-03-17 14:05 ` [PATCH v2 4/4] regulator: act8865: Configure register access for act8600 Maarten ter Huurne
2016-03-23 13:43 ` Applied "regulator: act8865: Remove redundant dev lookups" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328193521.GH2350@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten@treewalker.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®