From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755592AbcC2D2J (ORCPT ); Mon, 28 Mar 2016 23:28:09 -0400 Received: from mail-by2on0083.outbound.protection.outlook.com ([207.46.100.83]:44076 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754192AbcC2D2H (ORCPT ); Mon, 28 Mar 2016 23:28:07 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O4S6YO-07-BGR-02 X-M-MSG: Date: Tue, 29 Mar 2016 11:28:48 +0800 From: Huang Rui To: Borislav Petkov CC: Guenter Roeck , Jean Delvare , , , Subject: Re: [PATCH v5 4/6] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm Message-ID: <20160329032847.GB18406@hr-amur2> References: <1459143136-2412-1-git-send-email-ray.huang@amd.com> <1459143136-2412-5-git-send-email-ray.huang@amd.com> <20160328093327.GC26651@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160328093327.GC26651@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(199003)(164054003)(24454002)(97756001)(4001350100001)(11100500001)(87936001)(50466002)(47776003)(1076002)(586003)(5008740100001)(33656002)(101416001)(86362001)(83506001)(23726003)(4326007)(1220700001)(81166005)(1096002)(92566002)(54356999)(76176999)(110136002)(50986999)(106466001)(19580395003)(33716001)(105586002)(2950100001)(2906002)(189998001)(77096005)(46406003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0850;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: a0e9bd39-5e13-422f-d99d-08d357822269 X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;2:BbjEF2rRSjZbJfWrhUI0ruZ5lJ+KNLgd0H918q0Fv/VEpr35Jmep/w4jGEtl4O9mA/fm9IVGW/pjgj4opAs6tT4BOFjZg9dI3DpUjEpnV+iJrujs+jQs9Dc9lAni22nRK7o7/5LtYbsp+ssvnNI8Fy6DcWscSCX3Qt/iBYYKzLDfpd2l1vXudrB11EqItufx;3:B6tWnZGKr0DeJZEch2FBrhy2KU4NH6RsdXvwBVufquRV65xocykglb4KvAm9ouD06yRj98XgiQOnJ/aTy7eKG3s4T0t+gnFu9Dz41yhZhubh3CznEiUXyAzjBkaKqXcdjUAiYNSIHi9N4UqO8sLf+tIMP8I3AOQkkr4+AMN357AV14QBmnLkKMEmA6gIsHDQrMmJYJ86SxYJQ+inn3RJg5hA+XKfkVe0+zLZsO8LK3U= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0850; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;25:QOJFcqGrl++3pB0wrLPfV0mQSw2NLU4cVCD9ZL4TtQlIqlpomIU8EovKfpbVvmTmOuaSAdk1UX3cPqrorck6x6RRJjgwsicgB10lEgXG2IuTE5GETNoTcZJxEqApfh+kZpRc3++n243yP4aSq89JlsbF50FuvHOHiZL0m3ipiY02JcRG3fE1K65TE6rqUTdGv3tJuxam92rT/4LWhqxvxsvH9zHSeDmDAmP+8JCzN3jjbXwcsWcabJQ+8k44zS5ctMFwSmlDssd/PNqM0F6SHp84EutsgSTNTSLPxabcnBZafA6QOJyGJGu46HoU0OH+16mHsDpAjE7Jh6ok0atjHYe+Iq7yBJacIm4Vn4H91jI9KsnK8Khk0UtB0SW+14n8AELmIiooauV7RJpe+05Q4Zh4dsXW6bLpmIUd8zaPsEnX9U/TkWvW7Wp4ywT0tRRo4vJoVlwMrFQJ3EdkkHRH8Ohh1mA9RUzt2UGIq8SqakSwE5eRNPe53CmnCIhiCaruPtkzbLNjFEy7vuRm0qgejPsfEtJk9mp8TFIbRqTlsnbKkePpZehURGlQhp1VmRZj2BtiDBQq8wMqkfhdppbvxA== X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;20:cL/Gjsypi57U1mTsZ+5VHJxFnuflYJ0EWgMOSjnvJ+tnGZxk1MtDk97Ac3WbMLycn537QCP1JNRkTn+AsibNPf9Yu4dePSc4LVRymNznUnar++bu7OEh6N+Eg6OkHFiaYNTfOGzRN5H/I7kXJ5PICTz6AXRpEP/iPHpOyUL+6vJG4ShmXtwmZp0C6wJxr1jPxGg8oMJd3KuXR6JdKDiG65p0IAqK7Aiv9mHIV1qs0dnNO+iRzVXiiUbOvFwtJW1cWMkQ0Tx4j3tptCCZKoYUZoEy0TejWIx+c6uQ4vGZvqwbxB6Fl56amX1FrRRav82192PrLKUNflMF29i2YmK/Iz33rCugTB6dxzCaizbU+hjDNttVLXfC/+ujCeP5WpTKSjDO2j70M3b4WejkAgIK/2HKcf/D8oigKPwxN/ND48WSa3T3hat+JdsyROvsgHCUdIXZZkM8uz/9+ra9ma5lHYjnDIsEsXnfJnI7LI9e9HnN1W3QCljq6Do8kQd0eRK6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13015025)(8121501046)(13018025)(13024025)(13023025)(13017025)(10201501046)(3002001);SRVR:BN4PR12MB0850;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0850; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;4:ch/FnuPs4TKr7vCrnf+ZDAyH2UqteUUO1kHCf6nw6EN9IN42i3p5ApxnLqSlt47sj0cCEYwch52I6dk9bAsob6pZcdUIAUjF2r7duYWlrxLjKsI631lAxGm5WfVQ+yrj3Q0QNR1X7muopykiomzH6MX32bTd0qx2mG+WzjEKiYJXhiSxzQVRhBf6xj3UY1rv6lAJAhhiAErzG8NwIZAKj2/3RTHSADX4PLIW4hL2tQePMOJVvhHKJMI4rRFA2mnHSM/WkVp/ADawBegWBJIRz7n4E+SGdGNIYP1LS+YTQeQK4ObBBuVs2G1nh/iIWB/M0ko2ZtjF3iCvHVt2/lnEQ5TJydrGha0Z17vLj+W7llhmWEWea7ebojf81hMEhQ5Oq+2srAZaYQmgBiwrQv08D5GXvRcTqNhE/Cs6p7x2clwGqrOAmtvPOIJsyjTd7xbxLLx6xDI7UO8pbmAT6amgLA== X-Forefront-PRVS: 0896BFCE6C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR12MB0850;23:jpATF813rFb6aPjjtYNv3adp69KeWGhm2X32RTn5M?= =?us-ascii?Q?DTopj4hqHrnfn4z2zqZp+4o3x4tW35Cvlj/b5n1pb4z+E3KMCRHq+o1TYpvM?= =?us-ascii?Q?hHdYfUckciSvIC1jwaHed4cQzb8dtzRs3m3OvgWGPibGVCvRqLpYeH78vFN/?= =?us-ascii?Q?MYhgCMNqz/ZZmSL3moacTfpGFw0ASxJQmC3la9jmXMBW5Lo4LyPEkr9DOsLX?= =?us-ascii?Q?o3ljWhWVm9YzZ5jn/aKIeCBJSu8i2nFSRvgha/AVZI8AXZJYIGA6bx/vj25G?= =?us-ascii?Q?YkgcLn+F6O1CGIy/JcwV33h7nOeYVRASt3cyMcw95oJZWt/sjPIajjwmC8IW?= =?us-ascii?Q?tpyrmcmZE5czL19YSkXQ5n9/lv+BfO1se6cP/eLMT9FU50Cip6dnI6B+wCAB?= =?us-ascii?Q?cG0KVBAQruIuOuNT8vQ9GRUiGi3a/Qo717csuPdGmlRot4O9jHn/RsGMFSND?= =?us-ascii?Q?77L5AWjwGIZ+Dm0mO7MuaBAS5KunYtqJOrlrZje9dXhIeS6eT9uQzEXCz3wP?= =?us-ascii?Q?VxEijj+XKkZfrmt/bgZxs5zDmUlcc3QthRUrxXU5qZp/Z4tzBsCdNBPeW6Y9?= =?us-ascii?Q?2ooYfZiD46yBGjUcePYaGyNZsnvPf8+gYViQEfqx4of/Bjk4gApxerh0BAka?= =?us-ascii?Q?rMtyhV/FHNL8SmzX85OvS75pCrRtL1XCK4tOnRs+x9+Z5vYm4io6vAKWj83Y?= =?us-ascii?Q?QEqoo6yFUgMtQlwJv7bxL2piT9WqQHZwi/p/iOjirwXGsV0hCOdL5DJdON7b?= =?us-ascii?Q?sjsNia+3hWBShQlAtKC0tbOnZcbyQCddGVutdfj4n8INArfEjy1hzmFBrUMy?= =?us-ascii?Q?1ciBbssj08wWsOt267EAn+fiVAM187cu6fJu6NVBzojs3yRIDXwO4QXBHn/H?= =?us-ascii?Q?aOEZAqRIB0ibzAYPygBXO46p+mwUgE3nwq1AjlcIBKFFDCl55GA8jUS4UDNV?= =?us-ascii?Q?Dw8llM51ssvR21moNiprd5qjDw3+7/fUXnqKdG42oPBlgbj+/rwS51RhhX3N?= =?us-ascii?Q?hdfeFQES0KzBN+6fC74TVyU1WEy+5QChmkYyzo0lkB3fA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;5:uYDt5bwch3zwu/iyFxy10NjQ8jXt8YPCWS0IVnQvbYeGZBPTclIhwQM/kP4rgsuHAR6ypLxxIfmCc5i3hLteOS4Aw4k5C+5NgZ+7sPaKie3eGqMYYD7dRtnb9VejsHueng4ajCe2+XM2mpTPXDhHJw==;24:x34S26SM4iBbk2pc3nrSA36rZxAAtbaYkeXuoWrRQkQw5NuvOyCb1/5PEhfSkVn8Lu3AKNG4jTsOiM1gP5DYtfBBVr397sBXEPhMdw+G19A=;20:yXAcL62uNifOOR5BLnk/DKyDo7k/38IKocBInhncY3g1IAYzO225R+eQ00mX/PlsauWlxS4yd1jEHDVt92S9bV9sZgV5IpApqrRmlY7dofpCbT+NpjU9KmznfEGhSVjkTZZQelMaTFR2jLfrla7k4Gy6btFrHjLWo4Yb9LdbEX+uVYBpMbGpe3z2k5U0cMUWgdYHYHZsQutAMuMOmy0QYxMhmkvf9mRPge4NaPU1/oALAdY6M4i873vR6d2r0P8i SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2016 03:28:01.9567 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0850 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2016 at 11:33:27AM +0200, Borislav Petkov wrote: > On Mon, Mar 28, 2016 at 01:32:14PM +0800, Huang Rui wrote: > > > > return 0; > > @@ -330,6 +446,9 @@ static int fam15h_power_init_data(struct pci_dev *f4, > > > > data->max_cu_acc_power = tmp; > > > > + /* set default interval as 10 ms */ > > Because...? > I checked with HW designer, milliseconds is also a reasonable interval of acc power. And I cannot set too long here, because several seconds will cause the read function to hang for that period of time. So I pick 10ms here, and actually, we can update the interval at /etc/sensors3.conf chip "fam15h_power-*" set power1_average_interval 0.01 Thanks, Rui