From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
xfs@oss.sgi.com, Dave Chinner <david@fromorbit.com>,
drbd-dev@lists.linbit.com,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Boaz Harrosh <boaz@plexistor.com>
Subject: Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h
Date: Tue, 29 Mar 2016 00:26:17 -0700 [thread overview]
Message-ID: <20160329072617.GB18920@infradead.org> (raw)
In-Reply-To: <1458627149-12988-2-git-send-email-ming.lei@canonical.com>
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -31,6 +31,7 @@
>
> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */
> #include <linux/blk_types.h>
> +#include <linux/bvec_iter.h>
>
> #define BIO_DEBUG
>
> @@ -40,10 +41,6 @@
> #define BIO_BUG_ON
> #endif
>
> -#define BIO_MAX_PAGES 256
> -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT)
> -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9)
I see no reason why these should be moved out of bio.h.
Otherwise this looks fine to me.
next prev parent reply other threads:[~2016-03-29 7:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 6:12 [PATCH 0/8] block: prepare for multipage bvecs Ming Lei
2016-03-22 6:12 ` [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei
2016-03-29 7:26 ` Christoph Hellwig [this message]
2016-03-29 8:53 ` Ming Lei
2016-03-22 6:12 ` [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei
2016-03-29 7:26 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei
2016-03-29 7:26 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-03-29 7:27 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-03-29 7:29 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
2016-03-29 7:29 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei
2016-03-29 7:31 ` Christoph Hellwig
2016-03-29 8:09 ` Lars Ellenberg
2016-03-22 6:12 ` [PATCH 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei
2016-03-29 7:31 ` Christoph Hellwig
2016-03-29 1:33 ` [PATCH 0/8] block: prepare for multipage bvecs Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329072617.GB18920@infradead.org \
--to=hch@infradead.org \
--cc=anton@tuxera.com \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=david@fromorbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=philipp.reisner@linbit.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®