From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932455AbcC2V3R (ORCPT ); Tue, 29 Mar 2016 17:29:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57753 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754572AbcC2V3Q (ORCPT ); Tue, 29 Mar 2016 17:29:16 -0400 Date: Tue, 29 Mar 2016 14:29:11 -0700 From: Andrew Morton To: Kent Overstreet Cc: Al Viro , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Refactor find_get_pages() & friends Message-Id: <20160329142911.f2b069c8af06f649b86ec993@linux-foundation.org> In-Reply-To: <20160309011643.GA23179@kmo-pixel> References: <20160309011643.GA23179@kmo-pixel> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2016 16:16:43 -0900 Kent Overstreet wrote: > Collapse redundant implementations of various gang pagecache lookup - this is > also prep work for pagecache iterator work Patch looks nice. Unfortunately filemap.c has changed rather a lot since 4.5. Can you please redo the patch some time? And a more informative changelog would be appropriate, although it's all pretty obvious. I don't know what "pagecache iterator work" is and I doubt if many other readers do either, so some illumination there wouldn't hurt.