From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757350AbcC2UCr (ORCPT ); Tue, 29 Mar 2016 16:02:47 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:50255 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481AbcC2UCq (ORCPT ); Tue, 29 Mar 2016 16:02:46 -0400 Date: Tue, 29 Mar 2016 13:02:47 -0700 From: Guenter Roeck To: Alexander Koch Cc: Jean Delvare , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, Michael Hornung Subject: Re: [PATCH 0/2] hwmon: adc128d818: Support operation mode 1 Message-ID: <20160329200247.GC27318@roeck-us.net> References: <1459278219-5573-1-git-send-email-mail@alexanderkoch.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459278219-5573-1-git-send-email-mail@alexanderkoch.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2016 at 09:03:37PM +0200, Alexander Koch wrote: > The ADC128D818 offers four different chip operation modes which vary in the > number and measurement types of the available input signals (see datasheet > sec. 8.4.1). > > The current version of the driver only supports the default chip operation mode > (mode 0), providing seven analog values and a temperature reading. > > This patch series adds support for operation mode 1 (eight analog inputs but no > temperature), selectable through the device tree attribute 'mode': > > adc1: adc128d818@1d { > compatible = "ti,adc128d818"; > reg = <0x1d>; > mode = /bits/ 8 <1>; > }; > > The changes are transparent as 'mode' defaults to mode 0 which yields the > previous behaviour. Code has been tested on real hardware using an evaluation > board. > > Alexander Koch (2): > hwmon: adc128d818: Implement chip mode selection > hwmon: adc128d818: Implement operation mode 1 > > drivers/hwmon/adc128d818.c | 113 +++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 95 insertions(+), 18 deletions(-) > Please send follow-up patches to linux-hwmon@vger.kernel.org. Thanks, Guenter