From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Georgi Djakov <georgi.djakov@linaro.org>,
David Collins <collinsd@codeaurora.org>
Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types
Date: Tue, 29 Mar 2016 16:09:31 -0700 [thread overview]
Message-ID: <20160329230931.GT2350@sirena.org.uk> (raw)
In-Reply-To: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Tue, Mar 29, 2016 at 03:58:40PM -0700, Stephen Boyd wrote:
> - if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS) {
> - ret = spmi_regulator_ftsmps_init_slew_rate(vreg);
> + if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS ||
> + vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_LO_SMPS ||
> + vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_HO_SMPS ||
> + vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_SMPS) {
> + ret = spmi_regulator_init_slew_rate(vreg);
This should be a switch statement. Otherwise this looks fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-29 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 22:58 Stephen Boyd
2016-03-29 23:09 ` Mark Brown [this message]
2016-03-30 14:36 ` Georgi Djakov
2016-03-30 18:09 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329230931.GT2350@sirena.org.uk \
--to=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-arm@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®