From: Herbert Xu <herbert@gondor.apana.org.au>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ben Greear <greearb@candelatech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Thomas Graf <tgraf@suug.ch>
Subject: Re: Question on rhashtable in worst-case scenario.
Date: Wed, 30 Mar 2016 22:09:33 +0800 [thread overview]
Message-ID: <20160330140933.GA19606@gondor.apana.org.au> (raw)
In-Reply-To: <1459346588.2055.6.camel@sipsolutions.net>
On Wed, Mar 30, 2016 at 04:03:08PM +0200, Johannes Berg wrote:
>
> But we really don't want that either - in the normal case where you
> don't create all these virtual interfaces for testing, you have a
> certain number of peers that can vary a lot (zero to hundreds, in
> theory thousands) where you *don't* have the same key, so we still want
> to have the rehashing if the chains get longer in that case.
insecure_elasticity only disables rehashing without growing, it
does not inhibit table expansion which is driven by the number of
objects in the whole table.
> It's really just the degenerate case that Ben is creating locally
> that's causing a problem, afaict, though it's a bit disconcerting that
> rhashtable in general can cause strange failures at delete time.
The failure is simple, rhashtable will rehash the table if a given
chain becomes too long. This simply doesn't work if you hash many
objects with the same key since the chain will never get shorter
even after a rehash (or expansion).
Therefore if your hashtable has to do this then you have to disable
the rehash logic using the insecure_elasticity flag.
Alternatively you can construct your own linked list for objects
with the same key outside of rhashtable and hash the list instead.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-03-30 14:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:29 Ben Greear
2016-03-29 16:16 ` Ben Greear
2016-03-30 9:14 ` Johannes Berg
2016-03-30 13:55 ` Herbert Xu
2016-03-30 14:03 ` Johannes Berg
2016-03-30 14:09 ` Herbert Xu [this message]
2016-03-30 16:38 ` David Miller
2016-03-30 16:52 ` Ben Greear
2016-03-31 7:46 ` Johannes Berg
2016-03-31 7:50 ` Herbert Xu
2016-03-31 15:29 ` Johannes Berg
2016-04-01 0:46 ` Herbert Xu
2016-04-01 18:17 ` Ben Greear
2016-04-01 21:34 ` Johannes Berg
2016-04-02 1:46 ` Herbert Xu
2016-04-02 18:33 ` Johannes Berg
2016-03-31 15:13 ` Ben Greear
2016-03-31 15:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330140933.GA19606@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®