From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Lee Jones <lee.jones@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: Tegra boots failing due to as3722 I/O errors
Date: Wed, 30 Mar 2016 09:46:46 -0700 [thread overview]
Message-ID: <20160330164646.GH2350@sirena.org.uk> (raw)
In-Reply-To: <56FBD164.7040707@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Wed, Mar 30, 2016 at 02:15:16PM +0100, Jon Hunter wrote:
> On second thoughts, is this the correct way to fix this? I see that
> there are some operators defined for get/set_bypass for a regulator and
> these are not specified for LDO6 either. However, even if they were I
> don't believe this will fix the problem alone.
If this is trying to implement bypass support it should use bypass
support (and the other things doing this fixed to do so).
> The failure is caused by _regulator_get_voltage() returning an error.
> This function does not check if the regulator is bypassed, but I am
> wondering if it should and then return the bypass voltage?
Yes, like we already do for switches. I'll send an untested patch
shortly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-30 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 19:03 Mark Brown
2016-03-30 11:31 ` Jon Hunter
2016-03-30 13:15 ` Jon Hunter
2016-03-30 16:46 ` Mark Brown [this message]
2016-03-31 14:45 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330164646.GH2350@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome