From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932944AbcC3RTe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2016 13:19:34 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:55747 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753640AbcC3RTc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2016 13:19:32 -0400
Date: Wed, 30 Mar 2016 10:19:27 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Anton Altaparmakov <anton@tuxera.com>, xfs@oss.sgi.com,
        Dave Chinner <david@fromorbit.com>, drbd-dev@lists.linbit.com,
        Philipp Reisner <philipp.reisner@linbit.com>,
        Lars Ellenberg <lars.ellenberg@linbit.com>,
        Boaz Harrosh <boaz@plexistor.com>
Subject: Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on
 CONFIG_BLOCK
Message-ID: <20160330171927.GA13320@infradead.org>
References: <1459354637-17415-1-git-send-email-ming.lei@canonical.com>
 <1459354637-17415-3-git-send-email-ming.lei@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1459354637-17415-3-git-send-email-ming.lei@canonical.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2016 at 12:17:11AM +0800, Ming Lei wrote:
> We will use bvec iterator to implement iterate_bvec(): lib/iov_iter.c.
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
>  include/linux/blk_types.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 86a38ea..fd8527b 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -26,8 +26,6 @@ struct bio_vec {
>  	unsigned int	bv_offset;
>  };
>  
> -#ifdef CONFIG_BLOCK
> -
>  struct bvec_iter {
>  	sector_t		bi_sector;	/* device address in 512 byte
>  						   sectors */
> @@ -39,6 +37,8 @@ struct bvec_iter {
>  						   current bvec */
>  };

I didn't catch this earlier, but shouldn't this also move to
bvec_iter.h? Or maybe just create a linux/bvec.h for the bvec, bvec_iter
and bvec iter macros given that those are the types used outside the
block layer as well.