From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbcCaHwd (ORCPT ); Thu, 31 Mar 2016 03:52:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52440 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbcCaHwb (ORCPT ); Thu, 31 Mar 2016 03:52:31 -0400 Date: Thu, 31 Mar 2016 00:52:28 -0700 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , linux-block@vger.kernel.org, Boaz Harrosh , Linux Kernel Mailing List , xfs@oss.sgi.com, Jens Axboe , Al Viro , Lars Ellenberg , Philipp Reisner , Anton Altaparmakov , drbd-dev@lists.linbit.com Subject: Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Message-ID: <20160331075228.GA2491@infradead.org> References: <1459354637-17415-1-git-send-email-ming.lei@canonical.com> <1459354637-17415-3-git-send-email-ming.lei@canonical.com> <20160330171927.GA13320@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 09:02:59AM +0800, Ming Lei wrote: > That way may cause trouble to blk_type.h because it needs bvec_iter, > then looks not good to always include bvec_iter.h into blk_type.h. I'd expect bvec.h to be always included in blk_types.h, and replace the inclusion of blk_types.h in fs.h eventually.