From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757075AbcCaOSu (ORCPT ); Thu, 31 Mar 2016 10:18:50 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:48432 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbcCaOSs (ORCPT ); Thu, 31 Mar 2016 10:18:48 -0400 Date: Thu, 31 Mar 2016 07:18:49 -0700 From: Guenter Roeck To: Linus Walleij Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: arm:collie_defconfig broken since commit ff2b135922 ("gpio: make the gpiochip a real device") Message-ID: <20160331141849.GA28107@roeck-us.net> References: <56F8BB39.5010708@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 03:26:49PM +0200, Linus Walleij wrote: > On Mon, Mar 28, 2016 at 7:03 AM, Guenter Roeck wrote: > > > arm:collie_defconfig is broken since commit ff2b135922 ("gpio: make the > > gpiochip a real device"). > > Oh I was worried that something like this would happen, but > hoped we could find it in linux-next, oh well. > I didn't have collie_defconfig in my list of qemu tests since last weekend. Shows that qemu boot tests _are_ valuable ;-). Question is how to get to a real solution. I tried calling gpiolib_dev_init() from gpiochip_add_data() if gpiolib was not initialized yet, but at least for collie this doesn't work, presumably since gpiochip_add_data() is called too early. I am currently looking into deferring device initialization from gpiochip_add_data() until gpiolib_dev_init() was called, as suggested by Alexandre. Guenter