mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "acme@kernel.org" <acme@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"eranian@google.com" <eranian@google.com>,
	"vincent.weaver@maine.edu" <vincent.weaver@maine.edu>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"acme@redhat.com" <acme@redhat.com>,
	"jolsa@redhat.com" <jolsa@redhat.com>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"ying.huang@linux.intel.com" <ying.huang@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/1] perf/core: don't find side-band event from all pmus
Date: Thu, 31 Mar 2016 11:25:58 -0300	[thread overview]
Message-ID: <20160331142558.GA27708@kernel.org> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077058AA5A8@SHSMSX103.ccr.corp.intel.com>

Em Thu, Mar 31, 2016 at 02:05:46PM +0000, Liang, Kan escreveu:
> 
> 
> > > +static void perf_event_sb_mask(unsigned int sb_mask,
> > > +			       perf_event_aux_output_cb output,
> > > +			       void *data)
> > > +{
> > > +	int sb;
> > > +
> > > +	for (sb = 0; sb < sb_nr; sb++) {
> > > +		if (!(sb_mask & (1 << sb)))
> > > +			continue;
> > > +		perf_event_sb_iterate(sb, output, data);
> > > +	}
> > > +}
> > 
> > > @@ -5852,7 +5910,8 @@ static void perf_event_task(struct task_struct
> > > *task,
> > >
> > >  	perf_event_aux(perf_event_task_output,
> > >  		       &task_event,
> > > -		       task_ctx);
> > > +		       task_ctx,
> > > +		       (1 << sb_task) | (1 << sb_mmap) | (1 << sb_comm));
> > >  }
> > 
> > So one side-effect of this change is that the above event can be delivered
> > 3 times if you're 'lucky'.
> > 
> > Acme; does userspace care?
> 
> Hi Arnaldo,
> 
> Do you think if it's an issue for userspace?

Trying to get context and decode what you guys wrote...

- Arnaldo

  reply	other threads:[~2016-03-31 14:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 18:24 kan.liang
2016-03-29 12:06 ` Peter Zijlstra
2016-03-31 14:05   ` Liang, Kan
2016-03-31 14:25     ` acme [this message]
2016-03-31 14:44   ` Arnaldo Carvalho de Melo
2016-03-31 14:56     ` Peter Zijlstra
2016-03-31 16:21       ` Peter Zijlstra
2016-03-31 16:22         ` Peter Zijlstra
2016-04-06  8:09           ` Peter Zijlstra
2016-04-06 14:25             ` Liang, Kan
2016-05-12 13:30           ` Liang, Kan
2016-05-12 14:00             ` Peter Zijlstra
2016-06-03 10:49 ` [tip:perf/core] perf/core: Optimize side-band event delivery tip-bot for Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331142558.GA27708@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.weaver@maine.edu \
    --cc=ying.huang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome