From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758912AbcDAPKW (ORCPT ); Fri, 1 Apr 2016 11:10:22 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45227 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbcDAPKV (ORCPT ); Fri, 1 Apr 2016 11:10:21 -0400 Date: Fri, 1 Apr 2016 17:10:17 +0200 From: Peter Zijlstra To: Daniel Lezcano Cc: Ingo Molnar , "open list:SCHEDULER" Subject: Re: [PATCH] sched/clock: Remove pointless test in cpu_clock/local_clock Message-ID: <20160401151017.GK3448@twins.programming.kicks-ass.net> References: <1459518409-9448-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459518409-9448-1-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2016 at 03:46:48PM +0200, Daniel Lezcano wrote: > Remove the duplicate test by directly calling sched_clock_cpu() and let the > static key act in this function instead. We can assume gcc is smart enough to > inline cpu_clock()/local_clock() to sched_clock_cpu(). Why assume if you can easily check; so does it indeed inline?