From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbcDBQef (ORCPT ); Sat, 2 Apr 2016 12:34:35 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38172 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbcDBQe2 (ORCPT ); Sat, 2 Apr 2016 12:34:28 -0400 Date: Sat, 2 Apr 2016 09:34:12 -0700 From: Mark Brown To: PC Liao Cc: tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, koro.chen@mediatek.com Message-ID: <20160402163412.GC2350@sirena.org.uk> References: <1459498877-5810-1-git-send-email-pc.liao@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KXlsDDyIxzhAJBYd" Content-Disposition: inline In-Reply-To: <1459498877-5810-1-git-send-email-pc.liao@mediatek.com> X-Cookie: If anything can go wrong, it will. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 216.2.64.20 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KXlsDDyIxzhAJBYd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 01, 2016 at 04:21:17PM +0800, PC Liao wrote: > +Optional properties: > +- mediatek,audio-codec-dai-capture: audio codec dai on capture path > + rt5645-aif1: Default setting. Connect rt5650 I2S1 for capture > + rt5645-aif2: Connect rt5650 I2S2 for capture No, this has exactly the same issue as the previous version. To repeat what I said last time I would expect that the driver should just specify the links between the DAIs. Look at how other devices reference DAIs. --KXlsDDyIxzhAJBYd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW//SDAAoJECTWi3JdVIfQDHYH/iWJfsoX7UzQYq2useXZkJhC /FcMRcYMhpwjzJgeWbm8B2Ux98cfogyAglS8b8yAo3wCkvD4O8u9M4Nru2O42j/y SUd+VdjywrYF/4WYNlbe/9GHmf6b2iiRLixjv/2eeuT58vjF903RyifamH7NswUb aurGtspPu38YvdeirdDYzK3DFtzq0RcHJItdXxnKi24+Gvs+564ueUDtKuG6XRkm PWifK+CzZmbqvwsciQmABwWxUPz3yfOX/S2YwkRia8wV7vKprdpg6Glx4hg6kRZz XGYVQt8bEYNcsMxVwT+ZOh/DIKCyGe7yq9fZkpNik5sAUleqLVZGJLX8qVP7MJU= =mcvv -----END PGP SIGNATURE----- --KXlsDDyIxzhAJBYd--