From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755086AbcDDJnF (ORCPT ); Mon, 4 Apr 2016 05:43:05 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35829 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbcDDJnC (ORCPT ); Mon, 4 Apr 2016 05:43:02 -0400 Date: Mon, 4 Apr 2016 11:42:59 +0200 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner Subject: Re: [PATCH] mm:vmscan: clean up classzone_idx Message-ID: <20160404094259.GC13463@dhcp22.suse.cz> References: <1459727185-5753-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459727185-5753-1-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 04-04-16 08:46:25, Minchan Kim wrote: > [1] removed classzone_idx so we don't need code related to it. > This patch cleans it up. > > [1] mm, oom: rework oom detection As per http://lkml.kernel.org/r/20160404094213.GB13463@dhcp22.suse.cz the removal of classzone_idx was unintentional and wrong. > > Cc: Johannes Weiner > Cc: Michal Hocko > Signed-off-by: Minchan Kim > --- > mm/vmscan.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index d84efa03c8a8..6e67de2a61ed 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2551,16 +2551,8 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc) > > for_each_zone_zonelist_nodemask(zone, z, zonelist, > gfp_zone(sc->gfp_mask), sc->nodemask) { > - enum zone_type classzone_idx; > - > if (!populated_zone(zone)) > continue; > - > - classzone_idx = requested_highidx; > - while (!populated_zone(zone->zone_pgdat->node_zones + > - classzone_idx)) > - classzone_idx--; > - > /* > * Take care memory controller reclaiming has small influence > * to global LRU. > -- > 1.9.1 > -- Michal Hocko SUSE Labs