From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753898AbcDDMLQ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Apr 2016 08:11:16 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:45744 "EHLO vps0.lunn.ch"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751065AbcDDMLO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Apr 2016 08:11:14 -0400
Date: Mon, 4 Apr 2016 14:10:45 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Bert Vermeulen <bert@biot.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        "moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,..." 
	<linux-arm-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: kirkwood: Add DTS for Linksys
 EA4200v2/EA4500
Message-ID: <20160404121045.GB21828@lunn.ch>
References: <1459770433-2876-1-git-send-email-bert@biot.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1459770433-2876-1-git-send-email-bert@biot.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 04, 2016 at 01:47:12PM +0200, Bert Vermeulen wrote:
> This platform is based on a Marvell 88E6282 SoC and 88E6171 switch.
> ---

Hi Bert

Under the --- it is normal to list what you have changed. That helps
the reviewer focus on just the changes.

>  arch/arm/boot/dts/kirkwood-viper.dts | 236 +++++++++++++++++++++++++++++++++++

Please include linksys in the filename.

ls *linksys*
armada-385-linksys-caiman.dts  armada-385-linksys.dtsi
armada-385-linksys-cobra.dts   armada-xp-linksys-mamba.dts

>  1 file changed, 236 insertions(+)
>  create mode 100644 arch/arm/boot/dts/kirkwood-viper.dts

Please add this file to the Makefile. And keep the entries in
alphabetical order.

Otherwise this looks good.

Thanks
	Andrew