From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbcDDQLn (ORCPT ); Mon, 4 Apr 2016 12:11:43 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:32962 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbcDDQLm (ORCPT ); Mon, 4 Apr 2016 12:11:42 -0400 Date: Mon, 4 Apr 2016 21:41:29 +0530 From: Sudip Mukherjee To: "Maciej S. Szmigiero" Cc: linux-kernel Subject: Re: [PATCH][RESEND] parport: parport_pc: PCI SIO access should also depend on SIO option Message-ID: <20160404161129.GA13924@sudip-laptop> References: <56F9A998.9030406@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56F9A998.9030406@maciej.szmigiero.name> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2016 at 12:00:56AM +0200, Maciej S. Szmigiero wrote: > CONFIG_PARPORT_PC_SUPERIO toggles Super IO chip support in parport_pc > code, however only code accessing SIO chip via ISA (or LPC) bus was > conditional on it. > > This patch makes SIO chip accesses via PCI bus also dependent on this > config option. > > It should be noted that Super IO support in parport_pc is needed only when > firmware has failed to make parallel port available either via PNP or > on standard I/O ranges and user has one of a few supported SIOs. > > Signed-off-by: Maciej S. Szmigiero > --- > This is a resend without functional changes. Resend was not required. I had your original patch. Have you tested it on hardware? regards sudip