From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932738AbcDEB5O (ORCPT ); Mon, 4 Apr 2016 21:57:14 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:57393 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932600AbcDEB5K (ORCPT ); Mon, 4 Apr 2016 21:57:10 -0400 X-AuditID: cbfee690-f79e56d0000012c4-d5-57031b6ee969 Date: Tue, 05 Apr 2016 10:57:01 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Paul Gortmaker , Lee Jones , Krzysztof Kozlowski , Laxman Dewangan Subject: Re: [RESEND PATCH] mfd: max77686: Use module_i2c_driver() instead of subsys initcall Message-id: <20160405015701.GA4228@samsunx.samsung> References: <1459809962-8883-1-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1459809962-8883-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsWyRsSkRDdPmjnc4O5aLos3b9cwWbx+YWix dN9qFov7X48yWlzeNYfNYsb5fUwW1/YeZ3Zg97hzbQ+bR2/zOzaPLf132T36tqxi9Pi8Sc5j /ZatTAFsUVw2Kak5mWWpRfp2CVwZU868ZC24ylLRdv8ncwPjE+YuRk4OCQETiU8bV7NA2GIS F+6tZ+ti5OIQEljBKLFp6082mKIfh25AJWYxSlzYf4gFwvnIKDFl0iJ2kCoWAVWJKXO2g41l E9CUaLr9A6xbRMBU4tfaF6wgNrPAZ6DuBZ4gtrBAvMTLqY8ZQWxeAWOJH/e3gc0REnCV2Ph/ CytEXFDix+R7LBC9WhLrdx5ngrClJR79nQFWzyngJvFm91Igm4NDVEBF4tXBepDbJASusUsc b3oCdZuAxLfJIEdzACVkJTYdgPpeUuLgihssExjFZiHZNgvJtllIti1gZF7FKJpakFxQnJRe ZKJXnJhbXJqXrpecn7uJERh/p/89m7CD8d4B60OMAhyMSjy8M98zhQuxJpYVV+YeYjQFumIi s5Rocj4wyvNK4g2NzYwsTE1MjY3MLc2UxHlfS/0MFhJITyxJzU5NLUgtii8qzUktPsTIxMEp 1cBoPC99dknl5ljFV5sZd98qEtVO4vuQyLup7x3/5ZTii7u/fuRo2aeokTmvhscpvu/yh4+v 1pef7H3VnbQiVnOfcU8Tt+8ek5hL2w6XzV9we3XyttMH3Y9VhGbI6hlZ9tc9/fXacrKg8HHr i1Msk001P6X0L2Y8EmPQdle2sr/r39zOh97X+zYrsRRnJBpqMRcVJwIAfueYlboCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t9jQd08aeZwg6a/TBZv3q5hsnj9wtBi 6b7VLBb3vx5ltLi8aw6bxYzz+5gsru09zuzA7nHn2h42j97md2weW/rvsnv0bVnF6PF5k5zH +i1bmQLYohoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTd MnOAblFSKEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZkw585K14CpLRdv9 n8wNjE+Yuxg5OSQETCR+HLrBBmGLSVy4tx7I5uIQEpjFKHFh/yEWCOcjo8SUSYvYQapYBFQl pszZDtbNJqAp0XT7B1i3iICpxK+1L1hBbGaBz0DdCzxBbGGBeImXUx8zgti8AsYSP+5vA5sj JOAqsfH/FlaIuKDEj8n3WCB6tSTW7zzOBGFLSzz6OwOsnlPATeLN7qVANgeHqICKxKuD9RMY ga5E6J6FpHsWku4FjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYJj/Jn0DsbDu9wP MQpwMCrx8M54zxQuxJpYVlyZe4hRgoNZSYQ3Row5XIg3JbGyKrUoP76oNCe1+BCjKTA8JjJL iSbnA9NPXkm8obGJmZGlkbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUaGI/KTZw6 q0g07c6VK0schVecsUxL3+l2yex/Cf+hee8E9ypEfZiZzK/l3a56TPvbp5WWhQt+TYhROngx Zff2Gk1fro9Xb68Tu5wVycdSvygn7O2KbYyxHo1Xoyf+/rp/fVPGKZX5VmX9jC/LBLxCDrY/ VQ19d/2XQ12gx+KNfTJHevvO/zwb8UeJpTgj0VCLuag4EQDf46LABwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, > The driver's init and exit function don't do anything besides adding and > deleting the I2C driver so the module_i2c_driver() macro could be used. > > Currently is not being used because the driver is initialized at subsys > initcall level, claiming that this is done to allow consumers devices to > use the resources provided by this driver. But dependencies are in DT so > manual ordering of init calls is not necessary any more. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Andi Shyti Thanks, Andi