From: Peter Zijlstra <peterz@infradead.org>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: "'Ingo Molnar'" <mingo@kernel.org>,
"'Srikar Dronamraju'" <srikar@linux.vnet.ibm.com>,
tglx@linutronix.de, efault@gmx.de, htejun@gmail.com,
linux-kernel@vger.kernel.org, tj@kernel.org,
torvalds@linux-foundation.org, yangds.fnst@cn.fujitsu.com,
hpa@zytor.com
Subject: Re: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage
Date: Wed, 6 Apr 2016 09:50:00 +0200 [thread overview]
Message-ID: <20160406075000.GF3430@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <007901d18fd8$8c1e7810$a45b6830$@cn.fujitsu.com>
On Wed, Apr 06, 2016 at 03:47:18PM +0800, Zhao Lei wrote:
> > If you change the above loop to something like:
> >
> > for (ca = task_ca(tsk); ca; ca = parent_ca(ca)) {
> > if (WARN_ON_ONCE(!ca->cpuusage))
> > continue;
> > this_cpu_ptr(ca->cpuusage)->usages[index] += cputime;
>
> Or s/ this_cpu_ptr/get_cpu_var to avoid preempt?
This is all called with rq->lock held, preemption is firmly disabled.
next prev parent reply other threads:[~2016-04-06 7:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:37 [PATCH v4 0/4] cpuacct: split usage " Zhao Lei
2016-03-22 8:37 ` [PATCH v4 1/4] cpuacct: rename parameter in cpuusage_write for readability Zhao Lei
2016-03-22 8:37 ` [PATCH v4 2/4] cpuacct: small restruct for cpuacct Zhao Lei
2016-03-22 8:37 ` [PATCH v4 3/4] cpuacct: Show possible_cpu in cpuacct Zhao Lei
2016-03-31 9:27 ` [tip:sched/core] sched/cpuacct: Show all possible CPUs in cpuacct output tip-bot for Zhao Lei
2016-03-22 8:37 ` [PATCH v4 4/4] cpuacct: split usage into user_usage and sys_usage Zhao Lei
2016-03-31 9:27 ` [tip:sched/core] sched/cpuacct: Split usage accounting " tip-bot for Dongsheng Yang
2016-04-04 14:03 ` Srikar Dronamraju
2016-04-06 6:54 ` Ingo Molnar
2016-04-06 7:47 ` Zhao Lei
2016-04-06 7:50 ` Peter Zijlstra [this message]
2016-04-06 10:32 ` Anton Blanchard
2016-04-06 11:08 ` Peter Zijlstra
2016-04-06 11:43 ` Zhao Lei
2016-04-06 11:59 ` [PATCH] sched/cpuacct: Check for NULL when using task_pt_regs() Anton Blanchard
2016-04-06 13:26 ` Srikar Dronamraju
2016-04-06 17:05 ` Zhao Lei
2016-04-13 7:43 ` Ingo Molnar
2016-04-13 11:01 ` Michael Ellerman
2016-04-13 11:21 ` Ingo Molnar
2016-04-11 6:16 ` Ping? " Michael Ellerman
2016-04-13 11:49 ` [tip:sched/core] " tip-bot for Anton Blanchard
2016-03-22 9:44 ` [PATCH v4 0/4] cpuacct: split usage into user_usage and sys_usage Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406075000.GF3430@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yangds.fnst@cn.fujitsu.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome