From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753112AbcDFS44 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Apr 2016 14:56:56 -0400
Received: from mga14.intel.com ([192.55.52.115]:6699 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752138AbcDFS4y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Apr 2016 14:56:54 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; 
   d="scan'208";a="80335044"
Date: Wed, 6 Apr 2016 11:56:38 -0700
From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Viresh Kumar <vireshk@kernel.org>, linux-kernel@vger.kernel.org,
        dmaengine@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Hans-Christian Egtvedt <egtvedt@samfundet.no>,
        Tejun Heo <tj@kernel.org>, Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Vineet Gupta <vgupta@synopsys.com>, stable@vger.kernel.org
Subject: Re: [PATCH v3 01/15] dmaengine: dw: fix master selection
Message-ID: <20160406185637.GA5168@vkoul-mobl.iind.intel.com>
References: <1458311094-94927-1-git-send-email-andriy.shevchenko@linux.intel.com>
 <1458311094-94927-2-git-send-email-andriy.shevchenko@linux.intel.com>
 <20160404170337.GC3515@vkoul-mobl.iind.intel.com>
 <1459789854.12167.6.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1459789854.12167.6.camel@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote:
> On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote:
> > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote:
> > > 
> > > +	/*
> > > +	 * We need controller-specific data to set up slave
> > > transfers.
> > > +	 */
> > > +	BUG_ON(chan->private && !dw_dma_filter(chan, chan-
> > > >private));
> > I don't think BUG_ON is apt here, gracefully failing and printing
> > that can
> > be better..
> 
> Hm, this is coming from the existing code.
> 
> I would prefer to keep this one as is since it's targeted to stable@,
> and I may issue sequential patch to replace BUG_ON. Sounds okay?

But since this is going stable, how about we remove here in the patch and
benefit stable tree as well?

Thanks
-- 
~Vinod