From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbcDFU4I (ORCPT ); Wed, 6 Apr 2016 16:56:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45237 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbcDFU4H (ORCPT ); Wed, 6 Apr 2016 16:56:07 -0400 Date: Wed, 6 Apr 2016 13:56:05 -0700 From: Greg KH To: Manav Batra Cc: bhaktipriya96@gmail.com, dilekuzulmez@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixes some checkpatch.pl warnings Message-ID: <20160406205605.GB13901@kroah.com> References: <20160406113807.GA19489@iiitd.ac.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160406113807.GA19489@iiitd.ac.in> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2016 at 04:38:07AM -0700, Manav Batra wrote: > CHECK: Alignment should match open parenthesis > WARNING: line over 80 characters > > Signed-off-by: Manav Batra > --- > drivers/staging/rts5208/ms.c | 66 ++++++++++++++++++++++++++------------------ > 1 file changed, 39 insertions(+), 27 deletions(-) Your subject is a bit "odd", please have it match the format that other patches that have been accepted for this driver follows... Also only do one thing per patch, you did multiple different things here. thanks, greg k-h