From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757390AbcDGUgW (ORCPT ); Thu, 7 Apr 2016 16:36:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:55560 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753180AbcDGUgU (ORCPT ); Thu, 7 Apr 2016 16:36:20 -0400 Date: Thu, 07 Apr 2016 16:36:16 -0400 (EDT) Message-Id: <20160407.163616.385449823878901734.davem@davemloft.net> To: dhowells@redhat.com Cc: joe@perches.com, linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. From: David Miller In-Reply-To: <1091.1460058308@warthog.procyon.org.uk> References: <20160407162309.21283.11482.stgit@warthog.procyon.org.uk> <1460046677.6715.95.camel@perches.com> <1091.1460058308@warthog.procyon.org.uk> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Apr 2016 13:36:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells Date: Thu, 07 Apr 2016 20:45:08 +0100 > David Miller wrote: > >> Yeah this custom stuff is really inappropriate given the excellent >> infrastructure we have these days... > > Excellent only if I can get at it to find out why the something went wrong. > If it's lost because the machine panics, then it is worthless. If you're ok with these kenter things spewing into the logs with the current facility, you can run the function tracer and have it record into the logs all the time too. I don't see any argument which is appropriate for keeping this stuff around.