From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755136AbcDGAHZ (ORCPT ); Wed, 6 Apr 2016 20:07:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51841 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754474AbcDGAHU (ORCPT ); Wed, 6 Apr 2016 20:07:20 -0400 Date: Wed, 6 Apr 2016 17:07:19 -0700 From: Greg Kroah-Hartman To: Felipe Balbi Cc: Lu Baolu , Oliver Neukum , Mathias Nyman , Lee Jones , Heikki Krogerus , Chanwoo Choi , MyungJoo Ham , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux Message-ID: <20160407000719.GA25418@kroah.com> References: <1457423628-3183-1-git-send-email-baolu.lu@linux.intel.com> <1457423628-3183-4-git-send-email-baolu.lu@linux.intel.com> <1457613583.2411.11.camel@suse.com> <20160310235716.GB2586@kroah.com> <5704A59C.8040500@linux.intel.com> <20160406092950.GC29930@kroah.com> <87pou32g6f.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pou32g6f.fsf@intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register a mux and > unregister a device (that has been fixed), but is there anything else ? I don't remember anymore, that was a few thousand emails ago... But the suggestion about using devm_* shows that the original author has very little understanding about how the driver model works at all, which doesn't give me much hope at the moment... greg k-h