From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756054AbcDGN65 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Apr 2016 09:58:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41221 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753515AbcDGN6z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Apr 2016 09:58:55 -0400
Date: Thu, 7 Apr 2016 15:58:52 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/6] perf mem: Add --ldlat option
Message-ID: <20160407135852.GA1512@krava.brq.redhat.com>
References: <1458823940-24583-1-git-send-email-jolsa@kernel.org>
 <1458823940-24583-2-git-send-email-jolsa@kernel.org>
 <20160324155758.GA32162@kernel.org>
 <20160326160638.GA27964@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160326160638.GA27964@krava.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 26, 2016 at 05:06:38PM +0100, Jiri Olsa wrote:
> On Thu, Mar 24, 2016 at 12:57:58PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Mar 24, 2016 at 01:52:15PM +0100, Jiri Olsa escreveu:
> > > Adding --ldlat option to specify desired latency
> > > for loads event.
> > > 
> > > Specify 50 as loads event latency:
> > > 
> > >   $ perf mem record -e ldlat-loads -v --ldlat 50 true
> > >   calling: record -W -d -e cpu/mem-loads,ldlat=50/P true
> > 
> > We have all this infrastructure to set per-event settings, on the
> > command line, and here we end up adding a separate command line option
> > to do that? Why not something like:
> > 
> > 	perf mem record -e ldlat-loads/lat=50/ true
> 
> will check ;-)

sry for delay..

the thing is, that we can already do that via record command:
  perf record -e "cpu/mem-loads,ldlat=30/" ls

but this option is in perf mem command, which provides
the way to use short config:
   $ perf mem record --ldlat 50 ls

and adds also '-W -d' options for record command:

  $ ./perf mem record -v --ldlat 50 ls 
  calling: record -W -d -e cpu/mem-loads,ldlat=50/P ls 

jirka