From: David Howells <dhowells@redhat.com>
To: linux-afs@lists.infradead.org
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 7/9] rxrpc: Don't assume transport address family and size when using it
Date: Thu, 07 Apr 2016 17:23:44 +0100 [thread overview]
Message-ID: <20160407162344.21283.13396.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20160407162256.21283.47849.stgit@warthog.procyon.org.uk>
Don't assume transport address family and size when using the peer address
to send a packet. Instead, use the start of the transport address rather
than any particular element of the union and use the transport address
length noted inside the sockaddr_rxrpc struct.
This will be necessary when IPv6 support is introduced.
Signed-off-by: David Howells <dhowells@redhat.com>
---
net/rxrpc/ar-ack.c | 4 ++--
net/rxrpc/ar-connevent.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c
index d0eb98e1391c..3cd9264806a4 100644
--- a/net/rxrpc/ar-ack.c
+++ b/net/rxrpc/ar-ack.c
@@ -833,8 +833,8 @@ void rxrpc_process_call(struct work_struct *work)
/* there's a good chance we're going to have to send a message, so set
* one up in advance */
- msg.msg_name = &call->conn->trans->peer->srx.transport.sin;
- msg.msg_namelen = sizeof(call->conn->trans->peer->srx.transport.sin);
+ msg.msg_name = &call->conn->trans->peer->srx.transport;
+ msg.msg_namelen = call->conn->trans->peer->srx.transport_len;
msg.msg_control = NULL;
msg.msg_controllen = 0;
msg.msg_flags = 0;
diff --git a/net/rxrpc/ar-connevent.c b/net/rxrpc/ar-connevent.c
index 4dc6ab81fd2f..291522392ac7 100644
--- a/net/rxrpc/ar-connevent.c
+++ b/net/rxrpc/ar-connevent.c
@@ -86,8 +86,8 @@ static int rxrpc_abort_connection(struct rxrpc_connection *conn,
rxrpc_abort_calls(conn, RXRPC_CALL_LOCALLY_ABORTED, abort_code);
- msg.msg_name = &conn->trans->peer->srx.transport.sin;
- msg.msg_namelen = sizeof(conn->trans->peer->srx.transport.sin);
+ msg.msg_name = &conn->trans->peer->srx.transport;
+ msg.msg_namelen = conn->trans->peer->srx.transport_len;
msg.msg_control = NULL;
msg.msg_controllen = 0;
msg.msg_flags = 0;
next prev parent reply other threads:[~2016-04-07 16:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:22 [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells
2016-04-07 16:23 ` [PATCH 1/9] afs: Wait for outstanding async calls before closing rxrpc socket David Howells
2016-04-07 16:23 ` [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled David Howells
2016-04-07 16:31 ` Joe Perches
2016-04-07 17:38 ` David Miller
2016-04-07 19:45 ` David Howells
2016-04-07 20:36 ` David Miller
2016-04-07 20:47 ` David Howells
2016-04-07 20:50 ` David Miller
2016-04-07 21:24 ` David Howells
2016-04-07 17:05 ` David Howells
2016-04-07 17:19 ` Joe Perches
2016-04-07 19:43 ` David Howells
2016-04-07 20:21 ` Joe Perches
2016-04-07 20:42 ` David Howells
2016-04-07 16:23 ` [PATCH 3/9] rxrpc: Move some miscellaneous bits out into their own file David Howells
2016-04-07 16:23 ` [PATCH 4/9] rxrpc: Static arrays of strings should be const char *const[] David Howells
2016-04-07 16:23 ` [PATCH 5/9] rxrpc: Differentiate local and remote abort codes in structs David Howells
2016-04-07 16:23 ` [PATCH 6/9] rxrpc: Don't pass gfp around in incoming call handling functions David Howells
2016-04-07 16:23 ` David Howells [this message]
2016-04-07 16:23 ` [PATCH 8/9] rxrpc: Absorb the rxkad security module David Howells
2016-04-07 16:23 ` [PATCH 9/9] rxrpc: Create a null security type and get rid of conditional calls David Howells
2016-04-11 19:35 ` [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Miller
2016-04-11 20:38 ` David Howells
2016-04-11 22:01 ` David Howells
2016-04-12 1:26 ` David Miller
2016-04-11 22:29 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407162344.21283.13396.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®