From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbcDGSUh (ORCPT ); Thu, 7 Apr 2016 14:20:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58657 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932227AbcDGSUe (ORCPT ); Thu, 7 Apr 2016 14:20:34 -0400 Date: Thu, 7 Apr 2016 14:20:30 -0400 From: Jessica Yu To: Jiri Kosina Cc: Dan Carpenter , Josh Poimboeuf , Miroslav Benes , Petr Mladek , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: livepatch: robustify klp_register_patch() API error checking Message-ID: <20160407182030.GA25804@packer-debian-8-amd64.digitalocean.com> References: <20160404203426.GA8200@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 07 Apr 2016 18:20:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Jiri Kosina [07/04/16 18:06 +0200]: >From: Jiri Kosina > >Commit 425595a7fc20 ("livepatch: reuse module loader code to write >relocations") adds a possibility of dereferncing pointers supplied by the >consumer of the livepatch API before sanity (NULL) checking them (patch >and patch->mod). > >Spotted by smatch tool. > >Reported-by: Dan Carpenter >Signed-off-by: Jiri Kosina Acked-by: Jessica Yu Thank you Jiri!