From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435AbcDHGTj (ORCPT ); Fri, 8 Apr 2016 02:19:39 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35839 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbcDHGTh (ORCPT ); Fri, 8 Apr 2016 02:19:37 -0400 Date: Fri, 8 Apr 2016 11:49:29 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List , Peter Zijlstra , Srinivas Pandruvada Subject: Re: [PATCH] cpufreq: Call cpufreq_disable_fast_switch() in sugov_exit() Message-ID: <20160408061929.GG9674@vireshk-i7> References: <2791888.n2Juh7mFmz@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2791888.n2Juh7mFmz@vostro.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-04-16, 23:38, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Due to differences in the cpufreq core's handling of runtime CPU > offline and nonboot CPUs disabling during system suspend-to-RAM, > fast frequency switching gets disabled after a suspend-to-RAM and > resume cycle on all of the nonboot CPUs. > > To prevent that from happening, move the invocation of > cpufreq_disable_fast_switch() from cpufreq_exit_governor() to > sugov_exit(), as the schedutil governor is the only user of fast > frequency switching today anyway. > > That simply prevents cpufreq_disable_fast_switch() from being called > without invoking the ->governor callback for the CPUFREQ_GOV_POLICY_EXIT > event (which happens during system suspend now). > > Fixes: b7898fda5bc7 (cpufreq: Support for fast frequency switching) > Signed-off-by: Rafael J. Wysocki Acked-by: Viresh Kumar -- viresh