From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758634AbcDHS3p (ORCPT ); Fri, 8 Apr 2016 14:29:45 -0400 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:35966 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751186AbcDHS3o (ORCPT ); Fri, 8 Apr 2016 14:29:44 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3868:3872:4321:4362:5007:6261:7875:7903:10004:10400:10848:10967:11232:11658:11914:12043:12296:12517:12519:12555:12740:13069:13311:13357:13439:14181:14659:14721:21080:21221:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cream12_1a7eb161a5953 X-Filterd-Recvd-Size: 2043 Date: Fri, 8 Apr 2016 14:29:40 -0400 From: Steven Rostedt To: Benjamin Poirier Cc: Michal Marek , joeyli , "Yann E . MORIN " , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements Message-ID: <20160408142940.6de077d5@gandalf.local.home> In-Reply-To: <1459619722-13695-1-git-send-email-bpoirier@suse.com> References: <1459619722-13695-1-git-send-email-bpoirier@suse.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Apr 2016 10:55:21 -0700 Benjamin Poirier wrote: > The parameter of Kconfig "source" statements does not need to be quoted. > The current regex causes many kconfig files to be skipped and hence, > dependencies to be missed. > > Also fix the whitespace repeat count. > > Signed-off-by: Benjamin Poirier Thanks for sending this. I'll apply it. Should this be marked for stable? And if so, how far back? -- Steve > --- > scripts/kconfig/streamline_config.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl > index f3d3fb4..7036ae3 100755 > --- a/scripts/kconfig/streamline_config.pl > +++ b/scripts/kconfig/streamline_config.pl > @@ -188,7 +188,7 @@ sub read_kconfig { > $cont = 0; > > # collect any Kconfig sources > - if (/^source\s*"(.*)"/) { > + if (/^source\s+"?([^"]+)/) { > my $kconfig = $1; > # prevent reading twice. > if (!defined($read_kconfigs{$kconfig})) {