mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: ahs3@redhat.com
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is being used
Date: Sat, 9 Apr 2016 04:21:06 +0200	[thread overview]
Message-ID: <201604090421.06414.arnd@arndb.de> (raw)
In-Reply-To: <5706833F.3000803@redhat.com>

On Thursday 07 April 2016, Al Stone wrote:
> >>>  config DEVPORT
> >>>       bool
> >>> -     depends on !M68K
> >>> +     depends on !M68K && !ARM64
> >>
> >> Why not fix the real bug here, it's odd that only these two arches need
> >> this disabled, don't you agree?
> 
> Agreed.  It does seem odd.  I'm not sure I understand which bug you're thinking
> is the real one, though -- that DEVPORT should be disabled in all places that
> don't have ISA or that arm64 needs to have /dev/port work properly?  Or perhaps
> I missed something else entirely...

We've had a similar problem recently with ISA drivers crashing when no PCI
host registers itself for the first 0x1000 I/O port addresses.

I think both the request_resource() function and /dev/ioport should be
changed to interface with the dynamic registration of I/O port ranges
so they only ever allow access on ports that are mapped into virtual memory.

	Arnd

  reply	other threads:[~2016-04-09  2:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 21:27 Al Stone
2016-04-07  0:18 ` Greg Kroah-Hartman
2016-04-07  7:26   ` Geert Uytterhoeven
2016-04-07 15:56     ` Al Stone
2016-04-09  2:21       ` Arnd Bergmann [this message]
2016-04-12  5:17       ` Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201604090421.06414.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=ahs3@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome