From: kbuild test robot <lkp@intel.com>
To: Waiman Long <Waiman.Long@hpe.com>
Cc: kbuild-all@01.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@kernel.org,
x86@kernel.org, Jiang Liu <jiang.liu@linux.intel.com>,
Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
Scott J Norton <scott.norton@hpe.com>,
Douglas Hatch <doug.hatch@hpe.com>,
Randy Wright <rwright@hpe.com>, Waiman Long <Waiman.Long@hpe.com>
Subject: Re: [PATCH v3] x86/hpet: Reduce HPET counter read contention
Date: Tue, 12 Apr 2016 04:22:09 +0800 [thread overview]
Message-ID: <201604120437.9DDhR95o%fengguang.wu@intel.com> (raw)
In-Reply-To: <1460405379-25294-1-git-send-email-Waiman.Long@hpe.com>
[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]
Hi Waiman,
[auto build test WARNING on tip/auto-latest]
[also build test WARNING on v4.6-rc3 next-20160411]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Waiman-Long/x86-hpet-Reduce-HPET-counter-read-contention/20160412-041402
config: x86_64-randconfig-x011-201615 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/hpet.c:786:3: warning: 'hpet_save' defined but not used [-Wunused-variable]
} hpet_save;
^
vim +/hpet_save +786 arch/x86/kernel/hpet.c
770 * If multiple CPUs are trying to access the HPET counter at the same time,
771 * we don't actually need to read the counter multiple times. Instead, the
772 * other CPUs can use the counter value read by the first CPU in the group.
773 *
774 * A sequence number whose lsb is a lock bit is used to control which CPU
775 * has the right to read the HPET counter directly and which CPUs are going
776 * to get the indirect value read by the lock holder. For the later group,
777 * if the sequence number differs from the expected locked value, they
778 * can assume that the saved HPET value is up-to-date and return it.
779 */
780 static struct {
781 /* Sequence number + bit lock */
782 int seq ____cacheline_aligned_in_smp;
783
784 /* Current HPET value */
785 u32 hpet ____cacheline_aligned_in_smp;
> 786 } hpet_save;
787 #define HPET_SEQ_LOCKED(seq) ((seq) & 1) /* Odd == locked */
788
789 /*
790 * Clock source related code
791 */
792 #ifdef CONFIG_SMP
793 static cycle_t read_hpet(struct clocksource *cs)
794 {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 32483 bytes --]
prev parent reply other threads:[~2016-04-11 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 20:09 Waiman Long
2016-04-11 20:21 ` Andy Lutomirski
2016-04-12 16:37 ` Waiman Long
2016-04-12 18:55 ` Waiman Long
2016-04-11 20:22 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201604120437.9DDhR95o%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=Waiman.Long@hpe.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=doug.hatch@hpe.com \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=kbuild-all@01.org \
--cc=linux-doc@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rwright@hpe.com \
--cc=scott.norton@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®