From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbcDLFUV (ORCPT ); Tue, 12 Apr 2016 01:20:21 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35956 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbcDLFUT (ORCPT ); Tue, 12 Apr 2016 01:20:19 -0400 Date: Tue, 12 Apr 2016 10:50:14 +0530 From: Viresh Kumar To: Keguang Zhang Cc: linux-pm@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 4/5] cpufreq: Loongson1: Use devm_kzalloc() instead of global structure Message-ID: <20160412052014.GR16238@vireshk-i7> References: <1460375759-20705-1-git-send-email-keguang.zhang@gmail.com> <1460375759-20705-4-git-send-email-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460375759-20705-4-git-send-email-keguang.zhang@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-04-16, 19:55, Keguang Zhang wrote: > From: Kelvin Cheung > > This patch uses devm_kzalloc() instead of global structure. > Why are you doing this? The commit log should contain that. > Signed-off-by: Kelvin Cheung > --- > drivers/cpufreq/loongson1-cpufreq.c | 63 ++++++++++++++++++++----------------- > 1 file changed, 35 insertions(+), 28 deletions(-) I don't have any issues with you doing this, but I don't think that's necessary to do. Acked-by: Viresh Kumar -- viresh