From: Tejun Heo <tj@kernel.org>
To: Howard Cochran <hcochran@kernelspring.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Howard Cochran <cochran@lexmark.com>
Subject: Re: [PATCH] writeback: Fix performance regression in wb_over_bg_thresh()
Date: Tue, 12 Apr 2016 07:13:57 -0400 [thread overview]
Message-ID: <20160412111357.GS24661@htj.duckdns.org> (raw)
In-Reply-To: <1457590359-5837-1-git-send-email-hcochran@kernelspring.com>
On Thu, Mar 10, 2016 at 01:12:39AM -0500, Howard Cochran wrote:
> Commit 947e9762a8dd ("writeback: update wb_over_bg_thresh() to use
> wb_domain aware operations") unintentionally changed this function's
> meaning from "are there more dirty pages than the background writeback
> threshold" to "are there more dirty pages than the writeback threshold".
> The background writeback threshold is typically half of the writeback
> threshold, so this had the effect of raising the number of dirty pages
> required to cause a writeback worker to perform background writeout.
...
> Fixes: 947e9762a8dd ("writeback: update wb_over_bg_thresh() to use
> wb_domain aware operations")
> Signed-off-by: Howard Cochran <hcochran@kernelspring.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
--
tejun
prev parent reply other threads:[~2016-04-12 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 6:12 Howard Cochran
2016-04-12 11:13 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412111357.GS24661@htj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cochran@lexmark.com \
--cc=hcochran@kernelspring.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®