On Tue, Apr 12, 2016 at 08:26:41PM +0530, Laxman Dewangan wrote: > Use BIT macro for register field definition and make constant as > unsigned when using in shift operator like instead of (3 << 30), > make it to (3U << 30). > > Signed-off-by: Laxman Dewangan > --- > drivers/soc/tegra/pmc.c | 42 +++++++++++++++++++++--------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) Does this matter at all? We use the explicit notation in quite a number of places and it works great. I'd like to avoid needless churn unless there is a very good reason to switch. Also this contains whitespace changes that remove the extra level of indentation that is used to separate register field definitions from the register definitions. Thierry