From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757074AbcDLQ3n (ORCPT ); Tue, 12 Apr 2016 12:29:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:57420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757036AbcDLQ3m (ORCPT ); Tue, 12 Apr 2016 12:29:42 -0400 Date: Tue, 12 Apr 2016 11:29:37 -0500 From: Rob Herring To: Marc Zyngier Cc: Thomas Gleixner , Jiang Liu , Jason Cooper , Will Deacon , Mark Rutland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 5/5] DT: arm,gic-v3: Documment PPI partition support Message-ID: <20160412162937.GA25932@rob-hp-laptop> References: <1460365075-7316-1-git-send-email-marc.zyngier@arm.com> <1460365075-7316-6-git-send-email-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460365075-7316-6-git-send-email-marc.zyngier@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2016 at 09:57:55AM +0100, Marc Zyngier wrote: > Add a decription of the PPI partitioning support. > > Signed-off-by: Marc Zyngier > --- > .../bindings/interrupt-controller/arm,gic-v3.txt | 34 ++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > index 007a5b4..4c29cda 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > @@ -11,6 +11,8 @@ Main node required properties: > - interrupt-controller : Identifies the node as an interrupt controller > - #interrupt-cells : Specifies the number of cells needed to encode an > interrupt source. Must be a single cell with a value of at least 3. > + If the system requires describing PPI affinity, then the value must > + be at least 4. You're winning for cell count... One alternative that would save adding a cell and keep it contained within would be just list the affinities in the GIC node in the form of ' ': ppi-affinity = <1 2 &cpu2 &cpu3>, <5 1 &cpu4>, ... This would be harder to parse though if you have a large number of PPIs with affinities. That said, I've got no real issue with this as is. Rob