From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992AbcDNCnJ (ORCPT ); Wed, 13 Apr 2016 22:43:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33479 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753273AbcDNCnH (ORCPT ); Wed, 13 Apr 2016 22:43:07 -0400 Date: Wed, 13 Apr 2016 22:43:04 -0400 (EDT) Message-Id: <20160413.224304.1473128420144564230.davem@davemloft.net> To: dvlasenk@redhat.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH] net: force inlining of netif_tx_start/stop_queue, sock_hold, __sock_put From: David Miller In-Reply-To: <1460130714-7779-1-git-send-email-dvlasenk@redhat.com> References: <1460130714-7779-1-git-send-email-dvlasenk@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Apr 2016 19:43:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denys Vlasenko Date: Fri, 8 Apr 2016 17:51:54 +0200 > Sometimes gcc mysteriously doesn't inline > very small functions we expect to be inlined. See > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66122 > Arguably, gcc should do better, but gcc people aren't willing > to invest time into it, asking to use __always_inline instead. > > With this .config: > http://busybox.net/~vda/kernel_config_OPTIMIZE_INLINING_and_Os, > the following functions get deinlined many times. ... > This patch fixes this via s/inline/__always_inline/. > > Code size decrease after the patch is ~2.5k: > > text data bss dec hex filename > 56719876 56364551 36196352 149280779 8e5d80b vmlinux_before > 56717440 56364551 36196352 149278343 8e5ce87 vmlinux > > Signed-off-by: Denys Vlasenko Applied to net-next, thanks.