From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: fix crash in tpm_tis deinitialization
Date: Wed, 13 Apr 2016 09:16:51 +0300 [thread overview]
Message-ID: <20160413061651.GA6986@intel.com> (raw)
In-Reply-To: <20160412172655.GA5759@obsidianresearch.com>
On Tue, Apr 12, 2016 at 11:26:55AM -0600, Jason Gunthorpe wrote:
> On Tue, Apr 12, 2016 at 07:26:27AM +0300, Jarkko Sakkinen wrote:
> > > This needs to be after ops is fenced, something like this.
> >
> > I would appreciate a supporting argument.
> >
> > I guess the argument here is that this will prevent user space from
> > issuing TPM commands after the shutdown command has been sent?
>
> It prevents everything including the kernel from issuing a command
^^^^^^^^^^^^^^^^^^^^
That lock is not used to exclude kernel access. Read lock is only taken
for the user space device in tpm-dev.c.
> after shutdown. The shutdown is sent as the last command and no other
> commands can follow it.
>
> It doesn't make any sense to allow commands to follow shutdown.
I agree with this.
> Jason
/Jarkko
next prev parent reply other threads:[~2016-04-13 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 16:05 Jarkko Sakkinen
2016-04-11 17:40 ` Jason Gunthorpe
2016-04-12 4:26 ` Jarkko Sakkinen
2016-04-12 17:26 ` Jason Gunthorpe
2016-04-13 6:16 ` Jarkko Sakkinen [this message]
2016-04-13 6:58 ` Jarkko Sakkinen
2016-04-13 17:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413061651.GA6986@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome