drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: kbuild test robot <fengguang.wu@intel.com>
To: Karol Herbst <nouveau@karolherbst.de>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Ben Skeggs <bskeggs@redhat.com>,
	Martin Peres <martin.peres@free.fr>
Subject: drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
Date: Wed, 13 Apr 2016 15:07:42 +0800	[thread overview]
Message-ID: <201604131531.CJokPLHc%fengguang.wu@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1c74a7f812b135d3df41d7c3671b647aed6467bf
commit: b71c0892631af3dd2aea708529d282a65c683be5 drm/nouveau/iccsense: implement for ina209, ina219 and ina3221
date:   4 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

next             reply	other threads:[~2016-04-13  7:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  7:07 kbuild test robot [this message]
2016-04-13  7:07 ` [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings kbuild test robot
2016-04-13  7:55   ` Martin Peres
2016-04-13 10:08     ` Karol Herbst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201604131531.CJokPLHc%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=bskeggs@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.peres@free.fr \
    --cc=nouveau@karolherbst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®