From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750909AbcDMQku (ORCPT ); Wed, 13 Apr 2016 12:40:50 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39000 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcDMQkt (ORCPT ); Wed, 13 Apr 2016 12:40:49 -0400 Date: Wed, 13 Apr 2016 17:40:35 +0100 From: Mark Brown To: Andy Shevchenko Cc: Vinod Koul , Viresh Kumar , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Rob Herring , Hans-Christian Egtvedt , Tejun Heo , Greg Kroah-Hartman , Mark Rutland , Vineet Gupta Message-ID: <20160413164035.GA29471@sirena.org.uk> References: <1458311094-94927-1-git-send-email-andriy.shevchenko@linux.intel.com> <1458311094-94927-9-git-send-email-andriy.shevchenko@linux.intel.com> <20160413155719.GS2274@localhost> <1460563548.6620.165.camel@linux.intel.com> <20160413161715.GU2274@localhost> <1460564513.6620.170.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <1460564513.6620.170.camel@linux.intel.com> X-Cookie: Love thy neighbor, tune thy piano. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 13, 2016 at 07:21:53PM +0300, Andy Shevchenko wrote: > On Wed, 2016-04-13 at 21:47 +0530, Vinod Koul wrote: > > On Wed, Apr 13, 2016 at 07:05:48PM +0300, Andy Shevchenko wrote: > > > The old is still supported and benefit is apparently in unifying > > > standard properties across the drivers. > > Hrmmm how is that? > The common usage for data-width property is "in bytes". And I like the > idea. I don't know why at all I chose to keep encoded value there in the > first place and no one commented at that time. I suppose because of > screwed device tree process. I think now it's better to follow some > standard / registered properties in new drivers. You're unfortunately still breaking compatibility with existing DTs using this property. Now, it does appear that there is very little use of this DMA controller on DT systems and judging by the somewhat odd compatible string and in tree DTs most of those are legacy so perhaps this isn't the end of the world but this isn't something that should be dismissed as a simple cleanup. --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXDnaCAAoJECTWi3JdVIfQ5coH/1awDHb/gcLQZ11b3h8XrVoC jM10efrQSvzzWgFO3BLGnRlFa/S/+IbG0Ta8CkaGPUyCmz2sxUxT6pcbIzG9Nzdc kJ5xKG35iojo4itdoI+ILUaUn//XMuZGwah2MfKYqqLp5j7mtffbWXkQEI/ABmkr kNzC6HwM0zFIIkGuRAOhJJWbVoeNJ67B6ACuUWe0vEyXewyCpImcT87SgkxaQsRj M2rKAMENXa0swEFSyNzF/rh7jkDUsu9SOoJhwo0kfM9DRkVr9g3Fa70o3h/+3O+J ZyN9AyxDZYeg8Yg2can5bdellP2uDPrIvPqEa9Tj71JQ5kFBIxIqK8YYTUyGzN0= =CHX2 -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu--