From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbcDNF3f (ORCPT ); Thu, 14 Apr 2016 01:29:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:34536 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbcDNF3e (ORCPT ); Thu, 14 Apr 2016 01:29:34 -0400 Date: Thu, 14 Apr 2016 01:29:30 -0400 (EDT) Message-Id: <20160414.012930.746981483324064373.davem@davemloft.net> To: lars.persson@axis.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com, eric.dumazet@gmail.com, larper@axis.com Subject: Re: [PATCH net v3] net: sched: do not requeue a NULL skb From: David Miller In-Reply-To: <1460443552-26710-1-git-send-email-larper@axis.com> References: <1460443552-26710-1-git-send-email-larper@axis.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Apr 2016 22:29:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Persson Date: Tue, 12 Apr 2016 08:45:52 +0200 > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > > We take the optimistic approach and continue running the queue after a > failure since it is unknown if later packets also will fail in the > validate path. > > Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock") > Signed-off-by: Lars Persson Applied and queued up for -stable, thanks.