From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbcDNGpz (ORCPT ); Thu, 14 Apr 2016 02:45:55 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40732 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbcDNGpy (ORCPT ); Thu, 14 Apr 2016 02:45:54 -0400 Date: Thu, 14 Apr 2016 07:45:47 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Maxime Ripard , linux-kernel@vger.kernel.org, rjendra@qti.qualcomm.com Message-ID: <20160414064547.GD18024@sirena.org.uk> References: <1460569154-25030-1-git-send-email-srinivas.kandagatla@linaro.org> <1460569154-25030-3-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eheScQNz3K90DVRs" Content-Disposition: inline In-Reply-To: <1460569154-25030-3-git-send-email-srinivas.kandagatla@linaro.org> X-Cookie: McDonald's -- Because you're worth it. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eheScQNz3K90DVRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 13, 2016 at 06:39:13PM +0100, Srinivas Kandagatla wrote: > This patch adds dummy function for regmap_can_raw_write() in the header > file, so that the code can be atleast compiled without regmap enabled. > This kind of setup is mostly tested using randomconfig or zero > day-testing. I'm not convinced that this isn't flagging real problems - it's hard to see how code can safely and sensibly be written which would use this without a dependency on regmap (and given that and the fact that we have no external users we should probably make it internal to the API). --eheScQNz3K90DVRs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXDzyaAAoJECTWi3JdVIfQlq0H/2PMRpN9cq4fDQ5wI4AZjhNc hpsJE5GqgUOIx/G4FM9xaOY79sE3JbsHwv0A0ok11NdUpDyAKL7VKJsFFg0drHLs NpeuW9P7LVv7ImJPWPxm0yi1R6TCtzssBgcfB+4dhfvIXyc/j95BM19RYj5OeVxK CsRxtmBIzbY6ZBfycjMA+1j1BavD4Ghy/Eo9VghHl2k6eLsuptydX9iT2/rb1qWS RNk5/tFNm9n8827pyHDJjIfgYSMKAPOUT04YMADVrUqJEw5qbobKI//gajpTTiJz 3kTijBULvKS+KH2M7hmv4+h4kbo6C1CuHjkQI18KYBWdvjfohlWmuybvgvbRll4= =iqMf -----END PGP SIGNATURE----- --eheScQNz3K90DVRs--