From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393AbcDNJcx (ORCPT ); Thu, 14 Apr 2016 05:32:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43552 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754238AbcDNJcu (ORCPT ); Thu, 14 Apr 2016 05:32:50 -0400 Date: Thu, 14 Apr 2016 12:32:31 +0300 From: Dan Carpenter To: "Nicholas A. Bellinger" , Bart Van Assche Cc: Ray Jui , Scott Branden , Jon Mason , target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] target/transport: Silence unitialized variable warnings Message-ID: <20160414093231.GB16549@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The core_scsi3_ua_for_check_condition() can return without initializing these variables. I have initialized them to zero so that it triggers a WARN_ON_ONCE() in that situation. Signed-off-by: Dan Carpenter diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index ab2bf12..851e634 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2884,7 +2884,8 @@ static int translate_sense_reason(struct se_cmd *cmd, sense_reason_t reason) const struct sense_info *si; u8 *buffer = cmd->sense_buffer; int r = (__force int)reason; - u8 asc, ascq; + u8 asc = 0; + u8 ascq = 0; bool desc_format = target_sense_desc_format(cmd->se_dev); if (r < ARRAY_SIZE(sense_info_table) && sense_info_table[r].key)