From: David Miller <davem@davemloft.net>
To: wangweidong1@huawei.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next] phy: make some bits preserved while setup forced mode
Date: Fri, 15 Apr 2016 20:13:40 -0400 (EDT) [thread overview]
Message-ID: <20160415.201340.75308332414545478.davem@davemloft.net> (raw)
In-Reply-To: <570F4A38.5090201@huawei.com>
From: Weidong Wang <wangweidong1@huawei.com>
Date: Thu, 14 Apr 2016 15:43:52 +0800
> When tested the PHY SGMII Loopback:
> 1.set the LOOPBACK bit,
> 2.set the autoneg to AUTONEG_DISABLE, it calls the
> genphy_setup_forced which will clear the bit.
>
> The BMCR_LOOPBACK bit should be preserved.
>
> As Florian pointed out that other bits should be preserved too.
> So I make the BMCR_ISOLATE and BMCR_PDOWN as well.
>
> Signed-off-by: Weidong Wang <wangweidong1@huawei.com>
Applied, thank you.
prev parent reply other threads:[~2016-04-16 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:59 [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit " Weidong Wang
2016-04-13 14:19 ` Sergei Shtylyov
2016-04-14 2:18 ` Weidong Wang
2016-04-13 18:41 ` Florian Fainelli
2016-04-14 3:42 ` Weidong Wang
2016-04-14 7:43 ` [PATCH net-next] phy: make some bits preserved " Weidong Wang
2016-04-16 0:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415.201340.75308332414545478.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome