From: Jonathan Woithe <jwoithe@just42.net>
To: Darren Hart <dvhart@infradead.org>
Cc: Micha?? K??pie?? <kernel@kempniu.pl>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fujitsu-laptop: Support radio LED
Date: Fri, 15 Apr 2016 15:30:15 +0930 [thread overview]
Message-ID: <20160415060015.GQ12741@marvin.atrad.com.au> (raw)
In-Reply-To: <20160415054417.GA127188@f23x64.localdomain>
Hi Darren
On Thu, Apr 14, 2016 at 10:44:52PM -0700, Darren Hart wrote:
> On Fri, Apr 15, 2016 at 03:03:33PM +0930, Jonathan Woithe wrote:
> > > I've made a couple cosmetic changes and queued to for-next. Please review
> > > and let me know if you have any concerns.
> >
> > Sure. Pardon my ignorance of such things, but what is the most
> > straight-forward way to review the queued commit (preferrably without
> > cloning an entire kernel git repo)?
>
> You can see the tree in the MAINTAINERS file, but I suppose that doesn't
> make it obvious how to browse it. You can do that via the git web
> interface on infradead.
Oh, there is a git-web interface on that server. I should have just
followed my instinct. Apologies for the noise.
> The direct link to this patch is here:
>
> http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/commit/34b5199d2b69f9be731233af2425c53cc7ff995b
The commit looks fine to me. My only question is whether Michal should be
credited explicitly as the author since the patch originated from him (I
essentially just added some comments). You know the process better than me
though so I'll leave it up to you.
Regards
jonathan
next prev parent reply other threads:[~2016-04-15 6:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:28 Michał Kępień
2016-03-18 12:04 ` Jonathan Woithe
2016-03-22 13:30 ` Michał Kępień
2016-03-23 7:51 ` Michał Kępień
2016-03-24 11:35 ` Jonathan Woithe
2016-04-10 2:30 ` Darren Hart
2016-04-10 10:52 ` Jonathan Woithe
2016-04-12 12:03 ` Michał Kępień
2016-04-12 12:49 ` Jonathan Woithe
2016-04-12 13:29 ` Michał Kępień
2016-04-12 12:36 ` Jonathan Woithe
2016-04-15 4:42 ` Darren Hart
2016-04-15 5:33 ` Jonathan Woithe
2016-04-15 5:44 ` Darren Hart
2016-04-15 6:00 ` Jonathan Woithe [this message]
2016-04-15 7:32 ` Darren Hart
2016-03-28 17:44 ` Darren Hart
2016-03-22 11:27 ` Pavel Machek
2016-04-12 12:26 ` Michał Kępień
2016-04-14 12:39 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415060015.GQ12741@marvin.atrad.com.au \
--to=jwoithe@just42.net \
--cc=dvhart@infradead.org \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®