From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbcDOVTr (ORCPT ); Fri, 15 Apr 2016 17:19:47 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:30896 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbcDOVTp (ORCPT ); Fri, 15 Apr 2016 17:19:45 -0400 Date: Fri, 15 Apr 2016 22:19:42 +0100 From: Paul Burton To: James Hogan , Ralf Baechle CC: , "Maciej W. Rozycki" , , Jonas Gorski , "Markos Chandras" , Alex Smith , "Kirill A. Shutemov" , Andrew Morton Subject: Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions Message-ID: <20160415211942.GA21163@NP-P-BURTON> References: <1460716620-13382-1-git-send-email-paul.burton@imgtec.com> <1460716620-13382-4-git-send-email-paul.burton@imgtec.com> <20160415191640.GE7859@jhogan-linux.le.imgtec.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20160415191640.GE7859@jhogan-linux.le.imgtec.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.100.200.59] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 08:16:40PM +0100, James Hogan wrote: > On Fri, Apr 15, 2016 at 11:36:51AM +0100, Paul Burton wrote: > > asm/pgtable-bits.h is included in 2 assembly files and thus has to > > in either of the assembly files that include it. > > That could do with rewording :-) Oops, it appears that I accidentally some words. Originally there was an extra line in the middle so that it read something like: asm/pgtable-bits.h is included in 2 assembly files and thus has to #ifdef around C code, however nothing defined by the header is used in either of the assembly files that include it. Ralf: Would you be ok with adding back that line to the commit message if this gets merged without needing a v2? > Otherwise > Reviewed-by: James Hogan Thanks James :) Paul