From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbcDRRks (ORCPT ); Mon, 18 Apr 2016 13:40:48 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54449 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbcDRRkr (ORCPT ); Mon, 18 Apr 2016 13:40:47 -0400 Date: Mon, 18 Apr 2016 13:40:39 -0400 (EDT) Message-Id: <20160418.134039.321599420584841995.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: willemb@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch -next] udp: fix if statement in SIOCINQ ioctl From: David Miller In-Reply-To: <20160418084449.GA12410@mwanda> References: <20160418084449.GA12410@mwanda> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Apr 2016 10:40:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter Date: Mon, 18 Apr 2016 11:44:49 +0300 > We deleted a line of code and accidentally made the "return put_user()" > part of the if statement when it's supposed to be unconditional. > > Fixes: 9f9a45beaa96 ('udp: do not expect udp headers on ioctl SIOCINQ') > Signed-off-by: Dan Carpenter Applied.