From: Mark Brown <broonie@kernel.org>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: gregkh@linuxfoundation.org, stefan@agner.ch,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Stefan Agner <stefan.agner@toradex.com>
Subject: Re: [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev
Date: Mon, 18 Apr 2016 14:01:26 +0100 [thread overview]
Message-ID: <20160418130126.GC3217@sirena.org.uk> (raw)
In-Reply-To: <1460978308-8062-2-git-send-email-bhuvanchandra.dv@toradex.com>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On Mon, Apr 18, 2016 at 04:48:27PM +0530, Bhuvanchandra DV wrote:
> +++ b/Documentation/ABI/testing/sysfs-bus-spi-spidev
> @@ -0,0 +1,8 @@
> +What: /sys/bus/spi/drivers/spidev/new_id
> +Date: March 2016
> +Description:
> + This allows to load spidev at runtime. new_id file accepts bus
> + number and chip select in 'B.C' format.
> + e.g.
> + To load spidev1.1 at runtime:
> + $ echo 1.1 > /sys/bus/spi/drivers/spidev/new_id
I would expect a new_id file to allow a new device identifier to be
added to a driver at runtime but this isn't doing that, it's specifying
by bus and chip select instead which is totally different to how we
normally bind SPI devices. That seems likely to cause confusion down
the line. I'd expect to be able to supply a DT compatible string or a
Linux SPI ID.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-18 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 11:18 [RFC 0/2] sysfs new_id file support for spidev Bhuvanchandra DV
2016-04-18 11:18 ` [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev Bhuvanchandra DV
2016-04-18 13:01 ` Mark Brown [this message]
2016-04-20 12:13 ` Bhuvanchandra DV
2016-04-20 12:17 ` Mark Brown
2016-04-20 13:11 ` Bhuvanchandra DV
2016-04-20 13:52 ` Mark Brown
2016-04-18 11:18 ` [RFC 2/2] spi core: Add new sysfs 'num_chipselect' file Bhuvanchandra DV
2016-04-18 12:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418130126.GC3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bhuvanchandra.dv@toradex.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stefan.agner@toradex.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome